-
-
Notifications
You must be signed in to change notification settings - Fork 4
Change property og:image:url to og:image #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The spec allows both but popular messenger prefer the property without `:url`
|
It seems like my changes are not causing the ci failures. |
|
Hey, thanks for your work! 🙂 this was already solved in #5 - as long as you only pass a simple string it will also only render a simple |
|
Maybe the spec does say that. But the reality is that the platforms react different to the properties. I want to define the dimensions of the image and still want only to use Another possibility would be to add bot Using This is an example of how wordpress does it: The Facebook Sharing Debugger shows no errors despite a missing id for facebook: https://developers.facebook.com/tools/debug/?q=https%3A%2F%2Fblog.church.tools%2Fblog%2Fniederschwellige-digitale-werbung%2F |
|
Would you be fine with a And because it's |
|
@Gummibeer both of your solutions sounds good to me |
|
Okay, will work on this today - should be released end of the day. 🙂 |
|
I've decided for the construct argument because it was easier to do the split the moment the URL is assigned and not afterwards.^^ https://github.com/Astrotomic/php-open-graph/releases/tag/0.5.0 |
|
thanks, i tested it and it works. |
The spec allows both but popular messenger prefer the property without
:urlEvery messenger i tested ignored the property
og:image:urland only usedog:image.Tested Messengers: