Add Temporal support & incidental performance improvements#52
Closed
cn-stephen wants to merge 10 commits intoAsyncBanana:masterfrom
Closed
Add Temporal support & incidental performance improvements#52cn-stephen wants to merge 10 commits intoAsyncBanana:masterfrom
cn-stephen wants to merge 10 commits intoAsyncBanana:masterfrom
Conversation
Lock files were gitignored — remove that and commit the generated lock file for reproducible installs.
Owner
|
Thanks! Could you split these changes into multiple pull requests for each feature/optimization? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @AsyncBanana :)
This PR adds runtime support for Temporal types, which otherwise throw at runtime. These ship as fully supported in TypeScript 6.0 and are stage4 https://tc39.es/proposal-temporal/ and solid as heck. They're not going anywhere!
Incidental performance improvements and a couple of tweaks for readability as I was passing through.
Also, a little housekeeping (package-lock, .node-version, quality checks in CI) hope you don't mind.
I hope this is acceptable for your great library!
Benchmark results:
mastervstemporalApplied benchmarks
microdiff (no cycles)
microdiff (with cycles)
Geometric mean (applied)
Theoretical benchmarks
microdiff (no cycles)
microdiff (with cycles)
Geometric mean (theoretical)
Summary