Skip to content

Conversation

@atehrani
Copy link
Contributor

@atehrani atehrani commented Jun 9, 2017

@slandelle Please review :)

* @param predicate the predicate
*/
void flushChannelPoolPartitions(Predicate<Object> predicate);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format and remove spaces

protected BoundRequestBuilder requestBuilder(Request prototype) {
return new BoundRequestBuilder(this, prototype).setSignatureCalculator(signatureCalculator);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format and remove spaces

public void flushChannelPoolPartitions(Predicate<Object> predicate) {
throw new UnsupportedOperationException();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format and remove spaces

public void flushChannelPoolPartitions(Predicate<Object> predicate) {
throw new UnsupportedOperationException();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format and remove spaces

@atehrani
Copy link
Contributor Author

@slandelle What is your formatting preference? Note that the above notes are pieces of code that I did not touch.

@slandelle
Copy link
Contributor

Note that the above notes are pieces of code that I did not touch.

Of course you did. Those are all the places you added new methods. When you hit enter to jump line, your IDE doesn't create an empty line, but one with as many white spaces as the previous cursor position. Those are the ones I ask you to remove to I don't have to reformat after merging your PR.

@atehrani
Copy link
Contributor Author

@slandelle My bad! 😭 Darn non-printable characters. The extra spaces should no longer be there.

@slandelle slandelle merged commit caec155 into AsyncHttpClient:master Jun 12, 2017
@slandelle
Copy link
Contributor

Thanks :)

@slandelle slandelle added this to the 2.1.0 milestone Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants