Skip to content

Feature/config builder enhacements #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Feature/config builder enhacements #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b98e7e2
added: properties async http client config
Jan 16, 2018
3ace675
added: test for properties async http client config
Jan 17, 2018
9bead53
Merge remote-tracking branch 'origin/master' into feature/config_buil…
Jan 17, 2018
3200eda
changed: formatting + license headers
Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
import io.netty.channel.EventLoopGroup;
import io.netty.handler.ssl.SslContext;
import io.netty.util.Timer;
import static org.asynchttpclient.config.AsyncHttpClientConfigDefaults.*;

import java.util.*;
import java.util.concurrent.ThreadFactory;
import java.util.function.Consumer;

import org.asynchttpclient.channel.ChannelPool;
import org.asynchttpclient.channel.DefaultKeepAliveStrategy;
import org.asynchttpclient.channel.KeepAliveStrategy;
Expand All @@ -33,14 +39,6 @@
import org.asynchttpclient.proxy.ProxyServerSelector;
import org.asynchttpclient.util.ProxyUtils;

import java.io.IOException;
import java.io.InputStream;
import java.util.*;
import java.util.concurrent.ThreadFactory;
import java.util.function.Consumer;

import static org.asynchttpclient.config.AsyncHttpClientConfigDefaults.*;

/**
* Configuration class to use with a {@link AsyncHttpClient}. System property can be also used to configure this object default behavior by doing: <br>
* -Dorg.asynchttpclient.nameOfTheProperty
Expand All @@ -49,18 +47,6 @@
*/
public class DefaultAsyncHttpClientConfig implements AsyncHttpClientConfig {

private static final String AHC_VERSION;

static {
try (InputStream is = DefaultAsyncHttpClientConfig.class.getResourceAsStream("/ahc-version.properties")) {
Properties prop = new Properties();
prop.load(is);
AHC_VERSION = prop.getProperty("ahc.version", "UNKNOWN");
} catch (IOException e) {
throw new ExceptionInInitializerError(e);
}
}

// http
private final boolean followRedirect;
private final int maxRedirects;
Expand Down
Loading