Skip to content

Conversation

@bfg
Copy link
Contributor

@bfg bfg commented Feb 28, 2019

Using maven wrapper helps at build stability. Changes:

  • added maven wrapper 0.5.3 configured to use maven 3.6.0
  • updated travis config and scripts to use maven wrapper

bfg added 2 commits February 28, 2019 17:47
Using maven wrapper helps at build stability. Changes:

* added maven wrapper `0.5.3` configured to use maven `3.6.0`
* updated travis config and scripts to use maven wrapper
@slandelle
Copy link
Contributor

No, I don't want to use maven wrapper. I already have all my local set up and maven config that works fine. And I already use maven 3.6.0.

@slandelle
Copy link
Contributor

Then, adding javadoc:javadoc to CI is a good thing. I'm pretty surprised that install doesn't generate it...

@bfg
Copy link
Contributor Author

bfg commented Feb 28, 2019

No problem, I'll investigate further until i solve javadoc issue.

@slandelle
Copy link
Contributor

Lombok will sadly always be a huge hack with brittle support from other tools...

@bfg bfg closed this Feb 28, 2019
@bfg bfg deleted the enable_maven_wrapper branch February 28, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants