Skip to content

upgrade netty and add the new netty http codec options #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

upgrade netty and add the new netty http codec options #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20f294d
upgrade netty and add the new netty http codec options
borissmidt Oct 20, 2021
2627641
Update pom.xml
borissmidt Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,12 @@ public interface AsyncHttpClientConfig {

int getHttpClientCodecInitialBufferSize();

boolean httpClientCodecParseHttpAfterConnectRequest();

boolean httpClientCodecAllowDuplicateContentLengths();

boolean httpClientCodecAllowPartialChunks();

boolean isDisableZeroCopy();

int getHandshakeTimeout();
Expand Down
34 changes: 34 additions & 0 deletions client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ public class DefaultAsyncHttpClientConfig implements AsyncHttpClientConfig {
private final int httpClientCodecMaxHeaderSize;
private final int httpClientCodecMaxChunkSize;
private final int httpClientCodecInitialBufferSize;
private final boolean httpClientCodecParseHttpAfterConnectRequest;
private final boolean httpClientCodecAllowDuplicateContentLengths;
private final boolean httpClientCodecAllowPartialChunks;
private final int chunkedFileChunkSize;
private final Map<ChannelOption<Object>, Object> channelOptions;
private final EventLoopGroup eventLoopGroup;
Expand Down Expand Up @@ -209,6 +212,9 @@ private DefaultAsyncHttpClientConfig(// http
int httpClientCodecMaxHeaderSize,
int httpClientCodecMaxChunkSize,
int httpClientCodecInitialBufferSize,
boolean httpClientCodecParseHttpAfterConnectRequest,
boolean httpClientCodecAllowDuplicateContentLengths,
boolean httpClientCodecAllowPartialChunks,
int chunkedFileChunkSize,
int webSocketMaxBufferSize,
int webSocketMaxFrameSize,
Expand Down Expand Up @@ -301,6 +307,9 @@ private DefaultAsyncHttpClientConfig(// http
this.httpClientCodecMaxHeaderSize = httpClientCodecMaxHeaderSize;
this.httpClientCodecMaxChunkSize = httpClientCodecMaxChunkSize;
this.httpClientCodecInitialBufferSize = httpClientCodecInitialBufferSize;
this.httpClientCodecParseHttpAfterConnectRequest = httpClientCodecParseHttpAfterConnectRequest;
this.httpClientCodecAllowDuplicateContentLengths = httpClientCodecAllowDuplicateContentLengths;
this.httpClientCodecAllowPartialChunks = httpClientCodecAllowPartialChunks;
this.chunkedFileChunkSize = chunkedFileChunkSize;
this.channelOptions = channelOptions;
this.eventLoopGroup = eventLoopGroup;
Expand Down Expand Up @@ -623,6 +632,15 @@ public int getHttpClientCodecInitialBufferSize() {
return httpClientCodecInitialBufferSize;
}

@Override
public boolean setHttpClientCodecParseHttpAfterConnectRequest() { return httpClientCodecParseHttpAfterConnectRequest}

@Override
public boolean setHttpClientCodecAllowDuplicateContentLengths() { return httpClientCodecAllowDuplicateContentLengths}

@Override
public boolean setHttpClientCodecAllowPartialChunks() { return httpClientCodecAllowPartialChunks}

@Override
public int getChunkedFileChunkSize() {
return chunkedFileChunkSize;
Expand Down Expand Up @@ -770,6 +788,9 @@ public static class Builder {
private int httpClientCodecMaxHeaderSize = defaultHttpClientCodecMaxHeaderSize();
private int httpClientCodecMaxChunkSize = defaultHttpClientCodecMaxChunkSize();
private int httpClientCodecInitialBufferSize = defaultHttpClientCodecInitialBufferSize();
private boolean httpClientCodecParseHttpAfterConnectRequest = defaultHttpClientCodecParseHttpAfterConnectRequest();
private boolean httpClientCodecAllowDuplicateContentLengths = defaultHttpClientCodecAllowDuplicateContentLengths();
private boolean httpClientCodecAllowPartialChunks = defaultHttpClientCodecAllowPartialChunks();
private int chunkedFileChunkSize = defaultChunkedFileChunkSize();
private boolean useNativeTransport = defaultUseNativeTransport();
private ByteBufAllocator allocator;
Expand Down Expand Up @@ -1217,6 +1238,19 @@ public Builder setHttpClientCodecInitialBufferSize(int httpClientCodecInitialBuf
return this;
}

public Builder setHttpClientCodecParseHttpAfterConnectRequest(boolean httpClientCodecParseHttpAfterConnectRequest) {
this.httpClientCodecParseHttpAfterConnectRequest = httpClientCodecParseHttpAfterConnectRequest;
return this;
}
public Builder setHttpClientCodecAllowDuplicateContentLength(boolean httpClientCodecAllowDuplicateContentLengths) {
this.httpClientCodecAllowDuplicateContentLengths = httpClientCodecAllowDuplicateContentLengths;
return this;
}
public Builder setHttpClientCodecAllowPartialChunk(boolean httpClientCodecAllowPartialChunks) {
this.httpClientCodecAllowPartialChunks = httpClientCodecAllowPartialChunks;
return this;
}

public Builder setChunkedFileChunkSize(int chunkedFileChunkSize) {
this.chunkedFileChunkSize = chunkedFileChunkSize;
return this;
Expand Down
Loading