Reuse a per-thread UriParser scratch to avoid per-parse allocation#2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
UriParser.parse allocated a fresh parser on every call and returned it - the escape via the return value defeats scalar replacement, so it couldn't be optimized away, costing an allocation on every URL parse (i.e. every request).
Modification:
Reuse a per-thread UriParser scratch instance (held in a FastThreadLocal) instead of allocating per parse; the sole caller copies the parsed fields out synchronously before the scratch can be reused.
Result:
No per-parse UriParser allocation on the request path; parsed Uri output is unchanged, with a reentrancy test guarding the reuse.