Check in additional oauth tests #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the test, but I'm not found of adding 2 members just for tests. Why not simply delegate nonce and timestamp computation to protected methods that tests can override? Note that you declared testTimestamp as a Long wrapper, but then handle it as a primitive, causing a possible NPE. Thanks! |
|
@wsargent I'll merge and clean up as I suggested. Thanks! |
slandelle
pushed a commit
that referenced
this pull request
Feb 23, 2015
Check in additional oauth tests
slandelle
added a commit
that referenced
this pull request
Feb 23, 2015
|
Ported on 1.9.x as of 692bad1 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a package level constructor for OAuthSignatureCalculator to directly set the nonce and timestamp for testing, and adds some tests to ensure that the requestbuilder is using the signature calculator correctly.