Skip to content

chore: Update button label in contest table (#3135)#3137

Merged
KATO-Hiro merged 2 commits intostagingfrom
#3135
Feb 5, 2026
Merged

chore: Update button label in contest table (#3135)#3137
KATO-Hiro merged 2 commits intostagingfrom
#3135

Conversation

@KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Feb 5, 2026

close #3135

Summary by CodeRabbit

  • UI Improvements

    • Updated display labels for ACL and JOI contest provider groups for improved clarity
  • Documentation

    • Added comprehensive testing documentation including preset creation and verification examples
  • Tests

    • Expanded test coverage for contest provider presets with additional validation scenarios

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

Updated UI labels for contest provider presets (ACL and JOI groups), expanded test coverage for prepareContestProviderPresets functionality with multiple preset verification tests, and added comprehensive documentation about testing this feature.

Changes

Cohort / File(s) Summary
UI Label Updates
src/lib/utils/contest_table_provider.ts
Updated button labels: "ACL" → "AtCoder Library (ACL)" and JOI Second Qual Round group header/buttonLabel shortened to "JOI 二次予選・本選".
Test Coverage Expansion
src/test/lib/utils/contest_table_provider.test.ts
Added extensive test cases for prepareContestProviderPresets() covering multiple preset types (DPs, ACL, JOI rounds) with verification of metadata, display configuration, size, and provider instances.
Documentation Updates
docs/guides/how-to-add-contest-table-provider.md
Added documentation sections detailing tests for prepareContestProviderPresets() including group name verification, metadata checks, provider count checks, and provider instance type validation with section identifiers and examples.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Buttons polished bright and clear,
ACL gets its proper cheer,
JOI names all simplified just right,
Tests expanded, documentation in sight!
Labels dance, coverage grows wide,
Quality improvements spread with pride!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main change: updating button labels in the contest table as specified in issue #3135.
Linked Issues check ✅ Passed The code changes fully implement the two label updates required by issue #3135: ACL→AtCoder Library (ACL) and JOI label simplification.
Out of Scope Changes check ✅ Passed Changes are limited to label updates in contest_table_provider.ts, documentation, and test expansion—all directly related to the linked issue requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch #3135

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit ee4ab7f into staging Feb 5, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3135 branch February 5, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] テーブルのボタンの表記を修正しましょう

1 participant