Skip to content

feat: add contests and tasks for flow #3522

Merged
KATO-Hiro merged 1 commit into
stagingfrom
#3520
May 13, 2026
Merged

feat: add contests and tasks for flow #3522
KATO-Hiro merged 1 commit into
stagingfrom
#3520

Conversation

@KATO-Hiro
Copy link
Copy Markdown
Collaborator

@KATO-Hiro KATO-Hiro commented May 13, 2026

  • Add pastbook2022 tasks (A-H) to prisma/tasks.ts
  • Add WUPC (wupc2019) to university contest regex and test cases
  • Add missing AtCoder Others contest name labels and type test cases (geocon2013, s8pc-3, maximum-cup-2013/2018, code-festival-2014-china-open, soundhound2018, pakencamp-2018-day3, tenka1-2012-qualB, nikkei2019-final, awtf2024, xmascon19)

Summary by CodeRabbit

リリースノート

  • 新機能

    • 典型アルゴリズム問題集(pastbook2022)の8つの問題(A~H)を追加
    • 早稲田大学プログラミングコンテスト(WUPC)に対応
    • 複数のAtCoderコンテストの表示に対応し、より多くのコンテストをサポート
  • テスト

    • コンテスト名とタイプの検証テストを拡充

…utils

- Add pastbook2022 tasks (A-H) to prisma/tasks.ts
- Add WUPC (wupc2019) to university contest regex and test cases
- Add missing AtCoder Others contest name labels and type test cases
  (geocon2013, s8pc-3, maximum-cup-2013/2018, code-festival-2014-china-open,
   soundhound2018, pakencamp-2018-day3, tenka1-2012-qualB, nikkei2019-final,
   awtf2024, xmascon19)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

📝 Walkthrough

Walkthrough

AtCoder コンテスト分類ロジックを拡張し、WUPC(Waseda University Programming Contest)対応を追加するとともに、ATCODER_OTHERS マッピングに複数の新規コンテスト接頭辞を追加。並行して、pastbook2022 コンテストのタスク定義を8問分(A~H)追加し、対応するテストケースを拡充。


Changes

コンテスト分類と名前ラベリング拡張

Layer / File(s) Summary
WUPC 大学別コンテスト対応
src/lib/utils/contest.ts
ATCODER_UNIVERSITIES マップに wupc: 'WUPC' を追加し、regexForAtCoderUniversity(ku|qu|ut|tt|tu|wu) に拡張して、wu*pcYYYY 形式の大学別コンテスト ID を認識可能に。
ATCODER_OTHERS マッピング拡張
src/lib/utils/contest.ts
geocon2013s8pc-3/s8pc-4maximum-cup-*code-festival-2014-*soundhound2018pakencamp-2018-day3tenka1-2012-qualBnikkei2019-finaljsc2019-final/jsc2025-finalDEGwer2023awtf2024xmascon19 など複数の新規接頭辞を追加。
コンテスト分類テスト拡充
src/test/lib/utils/test_cases/contest_type.ts, src/test/lib/utils/test_cases/contest_name_labels.ts
pastbook2022wupc2019 の大学別コンテスト、および上記の ATCODER_OTHERS マッピングすべてに対するテストケースを追加。

pastbook2022 タスク定義

Layer / File(s) Summary
pastbook2022 タスク登録
prisma/tasks.ts
「典型アルゴリズム問題集 上級〜エキスパート編」の 8 問(A~H)をタスク配列に追加。各エントリは contest_id: 'pastbook2022' を指定し、日本語の name/title を含む。

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes


Possibly related PRs


Poem

🏛️ WUPC がタスク集に仲間入り、
コンテストタイプは多彩に輝く
分類のマップは日々豊かに、
型付けられた問題たちが並び立つ
データとテストで確実に前へ 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive PRのタイトル「feat: add contests and tasks for flow」は、変更内容(pastbook2022タスク追加、WUPC対応、AtCoder「Others」コンテスト情報追加)の一部を指していますが、「flow」という用語が曖昧で、実装内容を十分に反映していません。 タイトルを「feat: add pastbook2022 tasks and university/other contests」など、主要な変更を明確に表す内容に修正してください。
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch #3520

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@prisma/tasks.ts`:
- Around line 7670-7725: The new pastbook2022_* task records in prisma/tasks.ts
(e.g., id 'pastbook2022_a', 'pastbook2022_b', ... 'pastbook2022_h') are missing
the required grade field; update each object to include a proper grade value (or
explicitly document/implement the importer defaulting behavior in this change)
so that any logic relying on task.grade or task.atcoder_problems_difficulty
continues to work; locate the inserted objects by their ids and add the grade
property to each record or add a comment and code change in the importer to
guarantee a default grade is assigned.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9b6c3f64-cceb-411c-b994-eb618c4b1250

📥 Commits

Reviewing files that changed from the base of the PR and between 1fa5f7a and 70df4a7.

📒 Files selected for processing (4)
  • prisma/tasks.ts
  • src/lib/utils/contest.ts
  • src/test/lib/utils/test_cases/contest_name_labels.ts
  • src/test/lib/utils/test_cases/contest_type.ts

Comment thread prisma/tasks.ts
Copy link
Copy Markdown
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit e618ee9 into staging May 13, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3520 branch May 13, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant