Skip to content

Docs fix#182

Merged
lipkau merged 9 commits into
AtlassianPS:masterfrom
FreZZZeR:DocsFix
May 20, 2020
Merged

Docs fix#182
lipkau merged 9 commits into
AtlassianPS:masterfrom
FreZZZeR:DocsFix

Conversation

@FreZZZeR
Copy link
Copy Markdown
Contributor

@FreZZZeR FreZZZeR commented May 9, 2020

Description

Docs fix for function Set-Attachement
Added and fixed Suppress Exclusion in Invoke-WebRequest, Set-TlsLevel

Motivation and Context

Fix bugs in documentation
Fix Suppress Exclusion in Invoke-WebRequest, Set-TlsLevel

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@FreZZZeR FreZZZeR requested review from a team as code owners May 9, 2020 18:35
@FreZZZeR
Copy link
Copy Markdown
Contributor Author

@lipkau , Hello!
In Azure Pipeline we have 2 errors when testing ConfluencePS functions

Context /ConfluencePS/Private/Invoke-WebRequest.ps1
  [-] passes PSAvoidOverwritingBuiltInCmdlets 116ms
    Expected $null, but got @(1, 161).
    70:                     $BadLines | Should -Be $null
    at <ScriptBlock>, /home/vsts/work/1/s/Release/Tests/PSScriptAnalyzer.Tests.ps1: line 70

Context /ConfluencePS/Private/Set-TlsLevel.ps1
  [-] passes PSReviewUnusedParameter 26ms
    Expected $null, but got @(6, 9).
    70:                     $BadLines | Should -Be $null
    at <ScriptBlock>, /home/vsts/work/1/s/Release/Tests/PSScriptAnalyzer.Tests.ps1: line 70

I tried using both functions on Windows 10 2004 Preview on WSL (Ubuntu 18.04, Ubuntu 20.04), and on virtual machine with Ubuntu 18.04 LTS
No one error took.
Can You explain how is your test works?

@FreZZZeR
Copy link
Copy Markdown
Contributor Author

@lipkau, I fixed all error.
I have no experience in team development using GIT.
Can you review my fixes?

Comment thread ConfluencePS/Private/Set-TlsLevel.ps1 Outdated
lipkau
lipkau previously approved these changes May 19, 2020
@FreZZZeR
Copy link
Copy Markdown
Contributor Author

Finally, documentation was fixed. Tests can be passed.

Copy link
Copy Markdown
Contributor Author

@FreZZZeR FreZZZeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes has been reviewed.

@lipkau lipkau self-requested a review May 20, 2020 06:49
@lipkau lipkau merged commit 2aa759a into AtlassianPS:master May 20, 2020
@FreZZZeR FreZZZeR deleted the DocsFix branch May 20, 2020 10:41
lipkau added a commit that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants