Skip to content

Exclude page body from Get-Page and Get-ChildPage calls#189

Merged
lipkau merged 5 commits into
AtlassianPS:masterfrom
shristi-dev:exclude_page_body
Mar 9, 2021
Merged

Exclude page body from Get-Page and Get-ChildPage calls#189
lipkau merged 5 commits into
AtlassianPS:masterfrom
shristi-dev:exclude_page_body

Conversation

@shri5ti
Copy link
Copy Markdown
Contributor

@shri5ti shri5ti commented Feb 27, 2021

Description

Get-Page and Get-ChildPage calls fetch page content along with its metadata. A new switch parameter has been introduced in order to avoid fetching page body.

Motivation and Context

  • Reduces result size where only metadata is required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@shri5ti shri5ti requested review from a team as code owners February 27, 2021 08:14
@shri5ti shri5ti changed the title Exclude page body Exclude page body from Get-Page and Get-ChildPage calls Feb 27, 2021
Copy link
Copy Markdown
Member

@lipkau lipkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the integration tests and the 2 inline comments.

Rest looks fine

Comment thread ConfluencePS/Public/Get-ChildPage.ps1 Outdated
Comment thread ConfluencePS/Public/Get-Page.ps1 Outdated
@shri5ti shri5ti force-pushed the exclude_page_body branch from 6be11b9 to c69145b Compare March 7, 2021 03:17
@shri5ti shri5ti force-pushed the exclude_page_body branch from 4190c2d to 6a0dcfe Compare March 7, 2021 04:16
@shri5ti shri5ti force-pushed the exclude_page_body branch from 6a0dcfe to 9fccca2 Compare March 7, 2021 04:48
@shri5ti
Copy link
Copy Markdown
Contributor Author

shri5ti commented Mar 7, 2021

Fix the integration tests and the 2 inline comments.

Rest looks fine

The integration tests were failing due to stale spaces on the Confluence instance. I've fixed the New-ConfluenceSpace test to clean these up.

Copy link
Copy Markdown
Contributor Author

@shri5ti shri5ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed integration tests

@shri5ti shri5ti requested a review from lipkau March 7, 2021 07:08
@lipkau lipkau merged commit ef5b426 into AtlassianPS:master Mar 9, 2021
lipkau added a commit that referenced this pull request May 18, 2026
Exclude page body from Get-Page and Get-ChildPage calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants