Skip to content

Fix support for new cloud page ids by increase id range#190

Merged
lipkau merged 5 commits into
AtlassianPS:masterfrom
lipkau:fix/#186-increase_id_range
May 1, 2021
Merged

Fix support for new cloud page ids by increase id range#190
lipkau merged 5 commits into
AtlassianPS:masterfrom
lipkau:fix/#186-increase_id_range

Conversation

@lipkau
Copy link
Copy Markdown
Member

@lipkau lipkau commented Apr 29, 2021

Description

Int32 is too small for the current ids of confluence cloud pages.
Changing their types to UInt64 should fix this.

Motivation and Context

closes #186

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau requested review from a team as code owners April 29, 2021 22:03
Copy link
Copy Markdown
Collaborator

@brianbunke brianbunke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for revisiting this! :shipit:

@lipkau lipkau merged commit 4492f32 into AtlassianPS:master May 1, 2021
@lipkau lipkau deleted the fix/#186-increase_id_range branch May 11, 2021 12:25
lipkau added a commit that referenced this pull request May 18, 2026
Fix support for new cloud page ids by increase id range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants