Path-aware view ordering for modal search; assorted fixes#301
Merged
Conversation
View block now derives a variable→predicate-URI-set map from the SELECT's BGPs (handling alternative property paths like rdfs:label|sh:name|... whose items are URIs) and drives three things from it: the order-by dropdown (one option per variable, deduped), auto-pickup of ORDER BY from the SELECT, and a COALESCE-style client-side sort key that prefers literals whose @xml:lang primary subtag matches $ac:lang. `ORDER BY ?label` baked into $select-labelled-string so the modal search returns alphabetically by label. Search modal: form moved into the modal-header with a magnifier submit button; `.search-form-modal` CSS extends `.search-form`'s flex layout so input + button fit naturally. Empty address-bar submit button removed from the navbar-form (its ldh:logo template was never added; pressing Enter still submits). $ac:lang now reads the primary subtag of navigator.language so existing `lang($ac:lang)` checks (which spec-match `xml:lang='en'` for input `'en'`, not for `'en-US'`) keep working under browser preferences like `en-US`. Block mousemove handler guards the LinkedDataHub.contents cache lookup with ixsl:contains to avoid a warning per pixel when the hovered document-body's URI isn't cached. Local-document navigation handlers (tab activate, tab-close fallback, popstate, generic link click) now strip the query string from $uri via ac:absolute-path before passing it to ldh:DocumentNavigate. The cache key downstream now matches document-body/@about / tab data-uri, both already canonicalised via ac:absolute-path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View block now derives a variable→predicate-URI-set map from the SELECT's BGPs (handling alternative property paths like rdfs:label|sh:name|... whose items are URIs) and drives three things from it: the order-by dropdown (one option per variable, deduped), auto-pickup of ORDER BY from the SELECT, and a COALESCE-style client-side sort key that prefers literals whose @xml:lang primary subtag matches $ac:lang.
ORDER BY ?labelbaked into $select-labelled-string so the modal search returns alphabetically by label.Search modal: form moved into the modal-header with a magnifier submit button;
.search-form-modalCSS extends.search-form's flex layout so input + button fit naturally.Empty address-bar submit button removed from the navbar-form (its ldh:logo template was never added; pressing Enter still submits).
$ac:lang now reads the primary subtag of navigator.language so existing
lang($ac:lang)checks (which spec-matchxml:lang='en'for input'en', not for'en-US') keep working under browser preferences likeen-US.Block mousemove handler guards the LinkedDataHub.contents cache lookup with ixsl:contains to avoid a warning per pixel when the hovered document-body's URI isn't cached.
Local-document navigation handlers (tab activate, tab-close fallback, popstate, generic link click) now strip the query string from $uri via ac:absolute-path before passing it to ldh:DocumentNavigate. The cache key downstream now matches document-body/@about / tab data-uri, both already canonicalised via ac:absolute-path.