This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Resolve the cwd and return the result from the parse method#24
Merged
keplersj merged 2 commits intoAtomLinter:masterfrom Aug 7, 2015
Merged
Resolve the cwd and return the result from the parse method#24keplersj merged 2 commits intoAtomLinter:masterfrom
keplersj merged 2 commits intoAtomLinter:masterfrom
Conversation
There were two things that were not ok. * The `cwd` was set to the file name * There was no return infront of `helpers.parse` This PR should fix those problems
Contributor
Author
|
This should fix the #23 |
Contributor
|
I'll have to test later, but iirc there is no need for a return in front of |
Contributor
Author
|
The linter messages are not shown if there is no return statement. |
lib/main.js
Outdated
Contributor
There was a problem hiding this comment.
return on this line is unnecessary
a.filter(x => x * x)is equal to
a.filter(function(x){ return x * x })
Contributor
Author
There was a problem hiding this comment.
Thanks for the explanation @steelbrain :). You learn something new everyday :)
Contributor
Author
|
I removed the return statement. On my local machine I was using a different syntax. ...then((output) => {
return ....
}); |
keplersj
added a commit
that referenced
this pull request
Aug 7, 2015
Resolve the cwd and return the result from the parse method
Contributor
|
This will be published in the next path update. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two things that were not ok.
cwdwas set to the file namehelpers.parseThis PR should fix those problems