This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Reference correct message property for file path #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit 2391e38, I began receiving the following error in Atom: Failed to run cargo Path must be a string. Received undefined This is because the following line of code joins the current directory path with message.file, which is undefined. message.file = path.join curDir, message.file Here message.file is undefined since the new linter message v2 object has the file path under message.location.file. See: https://steelbrain.me/linter/types/linter-message-v2.html The constructMessage function of lib/mode.coffee follows this specification, but linter-rust.coffee looks for the path in a different place. This commit simply updates linter-rust.coffee to reference the correct property.
Arcanemagus
approved these changes
Jan 25, 2019
Member
Arcanemagus
left a comment
Arcanemagus
left a comment
There was a problem hiding this comment.
Thanks for catching that!
Contributor
Author
|
That has to be the quickest I've ever had a merge request approved. You're awesome, thanks for maintaining this package! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 2391e38, I began receiving the following error in Atom:
This is because the following line of code joins the current directory path with
message.file, which is undefined.Here message.file is undefined since the new linter message v2 object has the file path under
message.location.file. See: https://steelbrain.me/linter/types/linter-message-v2.htmlThe
constructMessagefunction oflib/mode.coffeefollows this specification, butlinter-rust.coffeelooks for the path in a different place. This commit simply updateslinter-rust.coffeeto reference the correct property.