This repository was archived by the owner on Aug 7, 2023. It is now read-only.
Fixes "Unnamed Linter" badge in linter popup#72
Merged
Arcanemagus merged 2 commits intoAtomLinter:masterfrom Sep 21, 2016
bkrem:fix-provider-name
Merged
Fixes "Unnamed Linter" badge in linter popup#72Arcanemagus merged 2 commits intoAtomLinter:masterfrom bkrem:fix-provider-name
Arcanemagus merged 2 commits intoAtomLinter:masterfrom
bkrem:fix-provider-name
Conversation
Currently the linter comes up as "Unnamed Linter" for in-line linter popups. This commit fixes this by naming the provider as 'shellcheck'.
Arcanemagus
suggested changes
Sep 21, 2016
lib/main.coffee
Outdated
| helpers = require('atom-linter') | ||
| path = require('path') | ||
| provider = | ||
| name: 'shellcheck' |
Member
There was a problem hiding this comment.
It looks like the name should actually be ShellCheck from their repo here: https://github.com/koalaman/shellcheck
Contributor
Author
There was a problem hiding this comment.
Good point thank you, missed that. Will fix now.
Arcanemagus
approved these changes
Sep 21, 2016
Member
|
Thanks! |
Member
|
Published in v1.2.1. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the linter comes up as "Unnamed Linter" for Atom's in-line linter popups.
This commit fixes this by naming the provider as 'shellcheck'.