fix: fixed issue in confidential chat#30
Merged
Conversation
Member
maschad
commented
Mar 31, 2025
- Closes Async confidential chat completions not working #29
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the confidential chat module by updating the decryption logic for stream responses. Key changes include creating a synchronous decryption wrapper function, parsing raw JSON directly, and wrapping decrypted chunks conditionally.
Comments suppressed due to low confidence (2)
src/atoma_sdk/confidential_chat.py:742
- [nitpick] Consider using a dataclass for EncryptedData to improve code clarity and maintainability.
class EncryptedData:
src/atoma_sdk/confidential_chat.py:768
- [nitpick] Consider logging a message when decrypted JSON contains no choices, since silently skipping such chunks may obscure underlying issues.
if not decrypted_json.get('choices'):
Cifko
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.