Feature/refactoring#19
Merged
Merged
Conversation
- Deleted the CHANGELOG.md file as part of the project restructuring. - Introduced Vitest as the testing framework, adding configuration and initial test scripts in package.json. - Created test files for preload API and gateway config functionalities to ensure proper contract adherence and functionality.
- Bumped version to 1.0.4 in package.json and package-lock.json. - Added new devDependencies: `@testing-library/jest-dom`, `@testing-library/react`, `jsdom`, and `vitest`. - Refactored type definitions in env.d.ts and preload.ts to use a unified `ExecResult` type. - Exported functions `parseUserMessageWithAttachments` and `cleanDerivedTitle` for better accessibility. - Updated tests to reflect changes in the structure and ensure functionality.
- Added an exclusion for test files in tsconfig.json to improve type checking. - Refactored the import path for styles in main.tsx to point to the new index.css file. - Removed the obsolete styles.css file to streamline the project's styling structure.
- Introduced `useWelcomeNavigation` for improved navigation handling within the onboarding process. - Refactored skill management by integrating `useWelcomeSkillState`, streamlining skill connection logic. - Removed obsolete CSS classes related to model options and meta rows to simplify styling. - Updated onboarding styles to enhance UI consistency and user experience.
- Introduced new skill types including "media-understanding", "obsidian", and "github" to improve onboarding capabilities. - Added `AsyncRunner` type for better async action handling across onboarding hooks. - Implemented new hooks for managing skills, including `useWelcomeMediaUnderstanding`, `useWelcomeGitHub`, and `useWelcomeObsidian`, enhancing user interaction with these services. - Updated existing hooks to support new skill management features and improve overall onboarding flow. - Refactored state management in `useWelcomeState` to accommodate new skill functionalities and streamline navigation.
- Introduced a typed wrapper around `window.openclawDesktop` to centralize API access and improve testability. - Added functions `getDesktopApi`, `getDesktopApiOrNull`, and `isDesktopApiAvailable` for better API management. - Created comprehensive tests for the desktop API wrapper to ensure functionality and error handling. - Refactored various components to utilize the new API wrapper, enhancing code consistency and maintainability.
- Moved the main App component to a new file at `ui/app/App.tsx`. - Created a dedicated `routes.ts` file to centralize route definitions. - Updated imports across various components to reflect the new structure. - Introduced `ExecApprovalModal` for handling execution approval requests.
- Introduced new connection pages for Apple Notes, Apple Reminders, GitHub, Notion, Obsidian, Slack, Telegram, and Trello to enhance the onboarding experience. - Each page includes specific instructions and UI components for connecting to the respective services. - Implemented hooks and constants to manage connection states and configurations. - Improved user guidance with detailed steps and error handling for each integration.
- Updated the settings structure to include subdirectories for each tab, enhancing organization and clarity. - Introduced new connector modals for Telegram, Slack, Discord, iMessage, Signal, and WhatsApp, allowing users to configure their connections directly within the app. - Implemented hooks for managing connector statuses and interactions, improving the user experience during setup. - Updated tests to reflect the new structure and ensure functionality of the settings and connector components.
- Added new type exports in context.tsx for better type management. - Updated CSS classes in ErrorScreen and various chat components for improved styling consistency. - Refactored onboarding connection pages to use a scrollable class for better layout. - Simplified utility functions by importing from shared utils, reducing redundancy. - Enhanced the settings UI by applying consistent styling and layout adjustments across various components.
…nd typography - Added new CSS files for buttons, forms, layout, modals, and typography to enhance UI consistency. - Consolidated styles for onboarding connections and skills setup, improving the overall user experience. - Removed deprecated styles and organized CSS for better maintainability.
…SS to CSS Modules
- Added new SVG icon for OpenAI integration. - Introduced CSS Modules for chat components, including AssistantMessage, UserMessageBubble, and ChatComposer, improving style encapsulation and maintainability. - Refactored existing chat components to utilize new CSS classes, enhancing visual consistency and responsiveness. - Removed deprecated CSS files related to sidebar and session items, streamlining the codebase.
… styling - Converted various components including App, ExecApprovalModal, ConsentScreen, and onboarding pages to utilize CSS Modules, enhancing style encapsulation and maintainability. - Updated class names to follow camelCase convention, ensuring consistency across the codebase. - Improved overall UI consistency by applying new styles and removing deprecated CSS classes.
…hooks - Refactored chat components to use a new directory structure, moving files into a 'components' and 'hooks' subdirectory for better organization. - Updated import paths in ChatPage, StartChatPage, and App components to reflect the new structure. - Introduced new CSS modules for ChatComposer, ChatAttachmentCard, and other components, enhancing style encapsulation and maintainability. - Added tests for CopyMessageButton and message parsing utilities to ensure functionality and reliability.
- Introduced activeSessionKey in chatSlice to track the current session and prevent rendering stale messages. - Updated sessionCleared action to set activeSessionKey, ensuring messages are cleared appropriately when switching sessions. - Enhanced historyLoaded logic to deduplicate live assistant messages based on history text, improving message integrity. - Modified ChatPage to conditionally render messages based on activeSessionKey, enhancing user experience during session transitions.
… structure and functionality - Refactored smoke tests to use role-based queries for better compatibility with Vitest. - Simplified ChatPage by utilizing the useChatStream hook for managing chat stream events. - Enhanced SlackConnectPage by integrating SlackSetupInstructions for clearer setup guidance. - Updated GogPage to import UiCheckbox from the correct forms module. - Cleaned up TelegramModal by leveraging useTelegramConfig for managing state and configuration. - Reorganized SkillsIntegrationsTab to streamline imports and improve component structure. - Removed deprecated UI components and consolidated shared kit exports for better maintainability.
…ture - Enhanced vitest.config.ts and tsconfig.json to include new path aliases for better module resolution. - Updated import statements across various components to utilize the new aliases, improving code readability and maintainability. - Refactored gatewaySlice and other components to streamline imports from shared modules, ensuring consistency in the codebase. - Adjusted onboarding and settings components to reflect the new import structure, enhancing overall organization.
…user experience - Added a new compact links row in OtherTab for better organization of footer links. - Updated section titles and descriptions for clarity, including renaming "OpenClaw Folder" to "Folders". - Consolidated the "App" and "About" sections for a more streamlined interface. - Removed deprecated hints and reorganized footer links to improve accessibility and usability. - Adjusted CSS styles for the new layout, ensuring a cohesive design across the settings page.
…iderTile for improved styling - Replaced class names in ModelProvidersTab and ProviderTile with new CSS classes for better consistency and maintainability. - Adjusted layout structure in ProvidersView to enhance visual organization of provider tiles. - Updated styling to align with the new design standards, ensuring a cohesive user experience across the settings interface.
…atPage - Implemented a new CopyCodeButton component to allow users to copy code snippets directly from code blocks. - Enhanced markdown rendering in ChatPage to include a copy button overlay on code blocks, improving usability for developers. - Updated CSS styles for code block wrappers and buttons to ensure a cohesive design and user experience.
Ooooze
pushed a commit
that referenced
this pull request
Apr 3, 2026
* feat: add QQ Bot channel extension * fix(qqbot): add setupWizard to runtime plugin for onboard re-entry * fix: fix review * fix: fix review * chore: sync lockfile and config-docs baseline for qqbot extension * refactor: 移除图床服务器相关代码 * fix * docs: 新增 QQ Bot 插件文档并修正链接路径 * refactor: remove credential backup functionality and update setup logic - Deleted the credential backup module to streamline the codebase. - Updated the setup surface to handle client secrets more robustly, allowing for configured secret inputs. - Simplified slash commands by removing unused hot upgrade compatibility checks and related functions. - Adjusted types to use SecretInput for client secrets in QQBot configuration. - Modified bundled plugin metadata to allow additional properties in the config schema. * feat: 添加本地媒体路径解析功能，修正 QQBot 媒体路径处理 * feat: 添加本地媒体路径解析功能，修正 QQBot 媒体路径处理 * feat: remove qqbot-media and qqbot-remind skills, add tests for config and setup - Deleted the qqbot-media and qqbot-remind skills documentation files. - Added unit tests for qqbot configuration and setup processes, ensuring proper handling of SecretRef-backed credentials and account configurations. - Implemented tests for local media path remapping, verifying correct resolution of media file paths. - Removed obsolete channel and remind tools, streamlining the codebase. * feat: 更新 QQBot 配置模式，添加音频格式和账户定义 * feat: 添加 QQBot 频道管理和定时提醒技能，更新媒体路径解析功能 * fix * feat: 添加 /bot-upgrade 指令以查看 QQBot 插件升级指引 * feat: update reminder and qq channel skills * feat: 更新remind工具投递目标地址格式 * feat: Refactor QQBot payload handling and improve code documentation - Simplified and clarified the structure of payload interfaces for Cron reminders and media messages. - Enhanced the parsing function to provide clearer error messages and improved validation. - Updated platform utility functions for better cross-platform compatibility and clearer documentation. - Improved text parsing utilities for better readability and consistency in emoji representation. - Optimized upload cache management with clearer comments and reduced redundancy. - Integrated QQBot plugin into the bundled channel plugins and updated metadata for installation. * OK apps/macos/Sources/OpenClaw/HostEnvSecurityPolicy.generated.swift > openclaw@2026.3.26 check:bundled-channel-config-metadata /Users/yuehuali/code/PR/openclaw > node --import tsx scripts/generate-bundled-channel-config-metadata.ts --check [bundled-channel-config-metadata] stale generated output at src/config/bundled-channel-config-metadata.generated.ts ELIFECYCLE Command failed with exit code 1. ELIFECYCLE Command failed with exit code 1. * feat: 添加 QQBot 渠道配置及相关账户设置 * fix(qqbot): resolve 14 high-priority bugs from PR openclaw#52986 review DM routing (7 fixes): - #1: DM slash-command replies use sendDmMessage(guildId) instead of sendC2CMessage(senderId) - #2: DM qualifiedTarget uses qqbot:dm:${guildId} instead of qqbot:c2c:${senderId} - #3: sendTextChunks adds DM branch - #4: sendMarkdownReply adds DM branch for text and Base64 images - #5: parseAndSendMediaTags maps DM to targetType:dm + guildId - #6: sendTextToTarget DM branch uses sendDmMessage; MessageTarget adds guildId field - #7: handleImage/Audio/Video/FilePayload add DM branches Other high-priority fixes: - #8: Fix sendC2CVoiceMessage/sendGroupVoiceMessage parameter misalignment - #9: broadcastMessage uses groupOpenid instead of member_openid for group users - #10: Unify KnownUser storage - proactive.ts delegates to known-users.ts - #11: Remove invalid recordKnownUser calls for guild/DM users - #12: sendGroupMessage uses sendAndNotify to trigger onMessageSent hook - #13: sendPhoto channel unsupported returns error field - #14: sendTextAfterMedia adds channel and dm branches Type fixes: - DeliverEventContext adds guildId field - MediaTargetContext.targetType adds dm variant - sendPlainTextReply imgMediaTarget adds DM branch * fix(qqbot): resolve 2 blockers + 7 medium-priority bugs from PR openclaw#52986 review Blocker-1: Remove unused dmPolicy config knob - dmPolicy was declared in schema/types/plugin.json but never consumed at runtime - Removed from config-schema.ts, types.ts, and openclaw.plugin.json - allowFrom remains active (already wired into framework command-auth) Blocker-2: Gate sensitive slash commands with allowFrom authorization - SlashCommand interface adds requireAuth?: boolean - SlashCommandContext adds commandAuthorized: boolean - /bot-logs set to requireAuth: true (reads local log files) - matchSlashCommand rejects unauthorized senders for requireAuth commands - trySlashCommandOrEnqueue computes commandAuthorized from allowFrom config Medium-priority fixes: - #15: Strip non-HTTP/non-local markdown image tags to prevent path leakage - #16: applyQQBotAccountConfig clears clientSecret when setting clientSecretFile and vice versa - #17: getAdminMarkerFile sanitizes accountId to prevent path traversal - #18: URGENT_COMMANDS uses exact match instead of startsWith prefix match - #19: isCronExpression validates each token starts with a cron-valid character - #20: --token format validation rejects malformed input without colon separator - #21: resolveDefaultQQBotAccountId checks QQBOT_APP_ID environment variable * test(qqbot): add focused tests for slash command authorization path - Unauthorized sender rejected for /bot-logs (requireAuth: true) - Authorized sender allowed for /bot-logs - Non-requireAuth commands (/bot-ping, /bot-help, /bot-version) work for all senders - Unknown slash commands return null (passthrough) - Non-slash messages return null - Usage query (/bot-logs ?) also gated by auth check * fix(qqbot): align global TTS fallback with framework config resolution - Extract isGlobalTTSAvailable to utils/audio-convert.ts, mirroring core resolveTtsConfig logic: check auto !== 'off', fall back to legacy enabled boolean, default to off when neither is set. - Add pre-check in reply-dispatcher before calling globalTextToSpeech to avoid unnecessary TTS calls and noisy error logs when TTS is not configured. - Remove inline as any casts; use OpenClawConfig type throughout. - Refactor handleAudioPayload into flat early-return structure with unified send path (plugin TTS → global fallback → send). * fix(qqbot): break ESM circular dependency causing multi-account startup crash The bundled gateway chunk had a circular static import on the channel chunk (gateway -> outbound-deliver -> channel, while channel dynamically imports gateway). When two accounts start concurrently via Promise.all, the first dynamic import triggers module graph evaluation; the circular reference causes api exports (including runDiagnostics) to resolve as undefined before the module finishes evaluating. Fix: extract chunkText and TEXT_CHUNK_LIMIT from channel.ts into a new text-utils.ts leaf module. outbound-deliver.ts now imports from text-utils.ts, breaking the cycle. channel.ts re-exports for backward compatibility. * fix(qqbot): serialize gateway module import to prevent multi-account startup race When multiple accounts start concurrently via Promise.all, each calls await import('./gateway.js') independently. Due to ESM circular dependencies in the bundled output, the first import can resolve transitive exports as undefined before module evaluation completes. Fix: cache the dynamic import promise in a module-level variable so all concurrent startAccount calls share the same import, ensuring the gateway module is fully evaluated before any account uses it. * refactor(qqbot): remove startup greeting logic Remove getStartupGreetingPlan and related startup greeting delivery: - Delete startup-greeting.ts (greeting plan, marker persistence) - Delete admin-resolver.ts (admin resolution, greeting dispatch) - Remove startup greeting calls from gateway READY/RESUMED handlers - Remove isFirstReadyGlobal flag and adminCtx * fix(qqbot): skip octal escape decoding for Windows local paths Windows paths like C:\Users\1\file.txt contain backslash-digit sequences that were incorrectly matched as octal escape sequences and decoded, corrupting the file path. Detect Windows local paths (drive letter or UNC prefix) and skip the octal decoding step for them. * fix bot issue * feat: 支持 TTS 自动开关并清理配置中的 clientSecretFile * docs: 添加 QQBot 配置和消息处理的设计说明 * rebase * fix(qqbot): align slash-command auth with shared command-auth model Route requireAuth:true slash commands (e.g. /bot-logs) through the framework's api.registerCommand() so resolveCommandAuthorization() applies commands.allowFrom.qqbot precedence and qqbot: prefix normalization before any handler runs. - slash-commands.ts: registerCommand() now auto-routes by requireAuth into two maps (commands / frameworkCommands); getFrameworkCommands() exports the auth-required set for framework registration; bot-help lists both maps - index.ts: registerFull() iterates getFrameworkCommands() and calls api.registerCommand() for each; handler derives msgType from ctx.from, sends file attachments via sendDocument, supports multi-account via ctx.accountId - gateway.ts (inbound): replace raw allowFrom string comparison with qqbotPlugin.config.formatAllowFrom() to strip qqbot: prefix and uppercase before matching event.senderId - gateway.ts (pre-dispatch): remove stale auth computation; commandAuthorized is true (requireAuth:true commands never reach matchSlashCommand) - command-auth.test.ts: add regression tests for qqbot: prefix normalization in the inbound commandAuthorized computation - slash-commands.test.ts: update /bot-logs tests to expect null (command routed to framework, not in local registry) * rebase and solve conflict * fix(qqbot): preserve mixed env setup credentials --------- Co-authored-by: yuehuali <yuehuali@tencent.com> Co-authored-by: walli <walli@tencent.com> Co-authored-by: WideLee <limkuan24@gmail.com> Co-authored-by: Frank Yang <frank.ekn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.