rocksdb migration and node lightning integration#218
Merged
matthewjablack merged 8 commits intoJun 2, 2025
Merged
Conversation
- Replace deprecated rocksdb package with actively maintained classic-level - Update rocksdb-base.ts to use ClassicLevel API - Convert createReadStream() calls to async iterator pattern - Update Node.js requirement from v14 to v18 (required by classic-level) - Update TypeScript to 4.9.5 and @types/node to 18.11.9 - Add skipLibCheck: true to tsconfig to handle deprecated node-lightning types - Add migration documentation in rocksdb-to-classic-level-migration.md BREAKING CHANGE: Requires Node.js 18+ and database files are incompatible with previous RocksDB format
- Import bufio, checksum, crypto, bitcoind, wire, and noise packages from node-lightning - Create new @node-dlc/common package to resolve circular dependencies - Move BitField, ShortChannelId, ChannelId utilities to common package - Add lightning-specific functionality (ChannelKeys, CommitmentSecret, etc.) to core - Update all imports across packages to use new structure - Add comprehensive test suites for all imported packages - Document migration in node-lightning-migration-summary.md and circular-dependency-resolution.md This completes the absorption of deprecated node-lightning functionality into node-dlc
- Fix prettier formatting violations in all packages - Add return type annotations where missing - Update package.json lint scripts to only check lib folders - Add .eslintignore entries for problematic files - Create tsconfig.eslint.json for broader file inclusion - Fix TypeScript and ESLint configuration conflicts All packages now pass linting with no errors
matthewjablack
changed the title
matthewjablack
deleted the
feat/rocksdb-migration-and-node-lightning-integration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate rocksdb to classic leveldb (since rocksdb nodejs npm package is now deprecated) and integrate relevant node-lightning files into node-dlc (since #node-lightning hasn't been maintained in 2 years)