fix: remove backward compatibility heuristic for DlcOffer protocol version#237
Merged
matthewjablack merged 1 commit intomasterfrom Apr 8, 2026
Merged
Conversation
…rsion Remove the heuristic-based backward compatibility logic that was attempting to differentiate between old and new DlcOffer formats. The protocol_version field is now always read as a 4-byte u32 as specified in dlcspecs PR #163. This simplifies the parsing logic and ensures consistent handling of the protocol version field across all DlcOffer messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expirationparameter #163Changes
The previous implementation used a heuristic to detect whether a DlcOffer message contained a protocol_version field by peeking at the next 5 bytes and checking if they
looked like a reasonable protocol version (1-10) followed by a zero contract_flags byte.
This change removes that complexity and always expects the protocol_version field to be present as a 4-byte u32, which aligns with the current dlcspecs specification.
Test plan