[codex] Guard pre-ready MCP notifications#95
Merged
Conversation
34d0a5f to
5073fb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The subprocess MCP proxy already gates request methods before lifecycle readiness. This adds explicit proof that client notifications cannot bypass that lifecycle boundary into the downstream MCP server before
initializeandnotifications/initializedcomplete.Verification
Locally verified during the GitHub Actions billing outage:
cargo fmt --checkcargo test release_audit_subprocess_mcp_proxy_pre_ready_notification_smoke_drops_payload -- --nocapturecargo testcargo clippy --all-targets --all-features -- -D warningscargo run --locked -- release-auditGitHub Actions is expected to fail before code checkout while the account billing suspension is active, so this PR is intentionally draft/local-verified until Actions recovers.