Fix overly strict lifetime requirements for deserialization helpers#291
Merged
ohuopio merged 3 commits intoAtostek:masterfrom Jul 24, 2023
Merged
Fix overly strict lifetime requirements for deserialization helpers#291ohuopio merged 3 commits intoAtostek:masterfrom
ohuopio merged 3 commits intoAtostek:masterfrom
Conversation
Clippy frequently adds new lints. We don't want the build to break then.
Contributor
Author
|
Happy to split this up into separate PRs if you prefer. |
There is no need for the input data to live exactly as long as the deserializer.
This way we don't need to specify the bound everywhere.
This was referenced Jul 20, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 70.44% 70.36% -0.09%
==========================================
Files 111 111
Lines 20278 20261 -17
==========================================
- Hits 14285 14256 -29
- Misses 5993 6005 +12
☔ View full report in Codecov by Sentry. |
Member
|
Thanks. This is much appreciated. It seems that specifying trait bounds on an associated type works now better than it did ~3 years ago. |
Collaborator
|
Yes, these seem to be good improvements. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other improvements:
Keybound onKeyed::Kso that we don't need to specify it on every usage