[tests] replace hardcoded version strings with __version__ import#3
Merged
Merged
Conversation
6 hardcoded "1.4.3" assertions replaced with __version__ from memstack. Renamed test_health_version_is_1_4_2 → test_health_version_matches_package and test_mcp_server_version_is_1_4_2 → test_mcp_server_version_matches_package. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"1.4.3"version assertions with__version__import frommemstacktest_health_version_is_1_4_2→test_health_version_matches_package,test_mcp_server_version_is_1_4_2→test_mcp_server_version_matches_packageFiles changed
tests/test_cli.py— add__version__import, replace 1 hardcoded assertiontests/test_routes_health.py— add__version__import, replace 3 hardcoded assertions, rename methodtests/test_mcp_server.py— replace 2 hardcoded assertions, rename method (already had__version__import)Verification
git grep '"1\.4\.[0-3]"' -- tests/returns zero__version__python -m pytest tests/test_cli.py tests/test_routes_health.py tests/test_mcp_server.py -v— 104 passedruff checkandruff format --checkcleanKnown limitations
None — this is a pure test refactoring with no behavioral change.
🤖 Generated with Claude Code