Skip to content

Conversation

@m-dobler
Copy link
Contributor

@m-dobler m-dobler commented Dec 6, 2019

Fixes the computation of the predicted covariances after a motion command, by changing elementwise multiplication to matrix multiplication.

@coveralls
Copy link

coveralls commented Dec 6, 2019

Pull Request Test Coverage Report for Build 1096

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.305%

Files with Coverage Reduction New Missed Lines %
SLAM/GraphBasedSLAM/graph_based_slam.py 1 98.32%
PathPlanning/BatchInformedRRTStar/batch_informed_rrtstar.py 5 81.41%
Totals Coverage Status
Change from base Build 1094: 0.03%
Covered Lines: 6725
Relevant Lines: 7447

💛 - Coveralls

@m-dobler m-dobler marked this pull request as ready for review December 6, 2019 11:10
Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the bug and comment is welcome. But, could you keep the code before simplifying? . Because, this repo's aim is for learning algorithm. So the code should be same as algorithm. In this simulation case, it is possible to simplify the code, but in other simulation, it might be impossible.

Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-dobler Thank you!! Good catch : ).

@AtsushiSakai AtsushiSakai merged commit 410304a into AtsushiSakai:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants