Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds OpenTelemetry instrumentation to enochecker.
This includes logs, fastapi traces, and httpx traces.
All generated traces/logs are annotated with appropriate attributes (operation, variant, tick, ...).
Context is propagated from the gameserver to the checker, but not from the checker to the actual service.
Example traces generated with in-dev gameserver + fastvuln service. No change to the actual checker/service code is required.
To test this, set up an otel collector server. For the service:
OTEL_EXPORTER_OTLP_ENDPOINTto the URL of your OpenTelemetry collector.OTEL_EXPORTER_OTLP_HEADERS_AUTHORIZATIONto your authentication token.Hint: enochecker3 is currently incompatible with Python 3.14. You might have to create a file
.python-versionwith content3.13to fix that.Background: old version of pydantic, included via enochecker3 => fastapi => pydantic. Newest fastapi does not fix this.