Universal configure script#1022
Merged
Merged
Conversation
Contributor
Author
|
works for linux now |
Contributor
Author
|
This is probably ready to merge. Since the external dependencies are implicitly documented in both configure.sh and CI, I don't see a point of having another list of them in README. we can keep it if we want though |
stonedDiscord
approved these changes
Jul 25, 2024
Member
stonedDiscord
left a comment
stonedDiscord
left a comment
There was a problem hiding this comment.
eventually we should use this for the CI
Contributor
|
Are we sure on MingW for Windows? Afaik we currently use MSVC for AO2 Windows builds |
Contributor
Author
|
There's no issue in adding "or msvc" in readme and script, but msvc is a very buggy compiler in my experience and I avoid it if I can. |
stonedDiscord
approved these changes
Jul 31, 2024
Member
|
You can still use Qt creator to build with MSVC, but you'll have to deal with the dependencies yourself. I think this is a fair tradeoff and certainly better than before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale: it should be easily possible to get Qt, clone the repo then run
./configure.shand have it "just work" for the most part, for all 3 major platforms. macos support may be so-and-so for now.