Skip to content

Fix evidence not being consistently presentable#1048

Merged
in1tiate merged 2 commits into
masterfrom
bugfix_present_evidence
Sep 8, 2024
Merged

Fix evidence not being consistently presentable#1048
in1tiate merged 2 commits into
masterfrom
bugfix_present_evidence

Conversation

@Salanto
Copy link
Copy Markdown
Contributor

@Salanto Salanto commented Sep 8, 2024

closes #1047

@Salanto Salanto requested a review from in1tiate September 8, 2024 05:27
@Salanto Salanto changed the title Fixup evidence presentation code, methink Fix evidence not being consistently presentable Sep 8, 2024
Copy link
Copy Markdown
Member

@in1tiate in1tiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Comment thread src/courtroom.cpp
// QString f_evi_name = local_evidence_list.at(f_evi_id - 1).name;
// def jud and hlp should display the evidence icon on the RIGHT side
bool is_left_side = !(side.startsWith("def") || side == "hlp");
bool is_left_side = !(side.startsWith("def") || side == "hlp"); // FIXME : Hardcoded
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doom#%

@in1tiate in1tiate merged commit fedf260 into master Sep 8, 2024
@in1tiate in1tiate deleted the bugfix_present_evidence branch September 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evidence present animation doesn't play sometimes

2 participants