Add "edit" and "open folder" actions for dropdowns by Crystalwarrior · Pull Request #776 · AttorneyOnline/AO2-Client

Crystalwarrior · 2022-06-02T23:17:19Z

CharSelect char button with edit char.ini, open this char folder, open base characters folder
pos dropdown with open this background, open base backgrounds folder
text color dropdown with open chat_config.ini
evidence button with open base evidence folder
sound list with open base sounds folder
music list with open base music folder

* CharSelect char button with edit char.ini, open this char folder, open characters folder * pos dropdown with open this background, open background(s) folder * text color dropdown with open chat_config.ini * evidence button with open evidence folder * sound list with open sounds folder * music list with open music folder

github-actions

clang-tidy made some suggestions

…heme" button

github-actions

clang-tidy made some suggestions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…line/AO2-Client into more-dropdown-actions

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

TrickyLeifa

Barely any of this works and the only that does work needs more work.

…s (so every mounted background folder is opened rather than just the latest one)

Suggestions implemented

oldmud0

There's some good stuff and some really bad stuff

stonedDiscord · 2022-07-30T12:52:58Z

how is this important for 2.10

…ightclick options

…the sfx is not "0" or "1"

Crystalwarrior · 2022-07-31T05:07:47Z

this PR's done, implemented Longbyte's and Leifa's requests

oldmud0 · 2022-07-31T16:39:10Z

+  menu->addAction(QString("Open base characters folder"), this,
                  [=] {
-    QString p_path = ao_app->get_real_path(VPath("characters/"));
+    QString p_path = ao_app->get_base_path() + "characters/";
    if (!dir_exists(p_path)) {
      return;
-}
+    }


what I really mean to say is, this button is not really useful. The only reason you want to open this folder is if you are looking for a character or you want to add a character, and in both cases the way to do it is with a different button.

oldmud0 · 2022-07-31T16:40:11Z

  menu->addSeparator();
-  menu->addAction(QString("Play"), this, &Courtroom::on_sfx_play_clicked);
+  // SFX is not "Nothing" or "Default"?
+  if (get_char_sfx() != "0" && get_char_sfx() != "1") {


I think - is also common for sfx.

- Base characters and base backgrounds folder buttons aren't generally u seful as usually these are mounted somewhere else. Easier to open the character or background folder and go up one level. - I decided to give the evidence, music, and sound lists the benefit of the doubt and kept their buttons for opening the base path, since there aren't many places to put an "open file location" button. - Added "-" to the list of SFX names to ignore when previewing.

oldmud0

approved with some modifications. I'm not really liking the "open base folder" concept as it does not go well with mounts. If there is a strong demand it may be worth making a file browser with QFileDialog and setting a proxy model so that it uses the vfs instead of the native file system.

github-actions Bot reviewed Jun 2, 2022

View reviewed changes

add "open themes folder" button for the settings menu under "reload t…

96f5d4d

…heme" button

github-actions Bot reviewed Jun 3, 2022

View reviewed changes

Comment thread src/aooptionsdialog.cpp Outdated

stonedDiscord and others added 11 commits June 6, 2022 19:19

braces

a7a17be

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bracesUpdate src/courtroom.cpp

fb7574e

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bracesUpdate src/courtroom.cpp

869d48b

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bracesbracesbracesUpdate src/aooptionsdialog.cpp

fee8624

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bracesbraces

f9d7c25

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

braces

dfc480f

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

braces

001bfc1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bracesUpdate braces

ad63800

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update sbraces

98364df

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

more braces, shut up bot

a476f01

Merge branch 'more-dropdown-actions' of https://github.com/AttorneyOn…

4e3bdb0

…line/AO2-Client into more-dropdown-actions

github-actions Bot reviewed Jun 6, 2022

View reviewed changes

stonedDiscord added 2 commits June 6, 2022 20:08

fuck you bot

cf7c768

bastard bot

d949e8f

github-actions Bot reviewed Jun 6, 2022

View reviewed changes

Crystalwarrior added this to the 2.10 milestone Jul 7, 2022

Crystalwarrior added 2 commits July 18, 2022 16:41

Merge branch 'master' into more-dropdown-actions

1ac558e

Fix build fail

a34b735

TrickyLeifa added enhancement Request for functionality not present engine/assets Issues related to INI parsing, path resolution, and asset loading labels Jul 22, 2022

TrickyLeifa previously requested changes Jul 26, 2022

View reviewed changes

Comment thread src/aooptionsdialog.cpp

Comment thread src/courtroom.cpp

Comment thread src/courtroom.cpp

Comment thread src/courtroom.cpp

Crystalwarrior added 4 commits July 27, 2022 16:26

Fix several actions not doing anything

da0560e

Expand the "open folder" buttons to open all recognized mounted folde…

3628ebe

…s (so every mounted background folder is opened rather than just the latest one)

I forgot about the themes button 😭

6abc6fa

Update "open themes folders" button texxt

4682f29

Crystalwarrior requested a review from TrickyLeifa July 27, 2022 17:20

oldmud0 reviewed Jul 29, 2022

View reviewed changes

Merge branch 'master' into more-dropdown-actions

8c2b6df

stonedDiscord removed this from the 2.10 milestone Jul 30, 2022

Change "open all mounted path folders" into just "open base folder" r…

04518b0

…ightclick options

Crystalwarrior requested a review from oldmud0 July 30, 2022 17:17

Implement "Play <sfx_name>" for the Play action, and only show it if …

e98e947

…the sfx is not "0" or "1"

Crystalwarrior requested review from stonedDiscord and removed request for TrickyLeifa July 31, 2022 05:06

oldmud0 requested changes Jul 31, 2022

View reviewed changes

oldmud0 reviewed Jul 31, 2022

View reviewed changes

oldmud0 approved these changes Jul 31, 2022

View reviewed changes

oldmud0 merged commit b9aa203 into master Jul 31, 2022

oldmud0 deleted the more-dropdown-actions branch July 31, 2022 18:05

Conversation

Crystalwarrior commented Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TrickyLeifa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oldmud0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stonedDiscord commented Jul 30, 2022

Uh oh!

Crystalwarrior commented Jul 31, 2022

Uh oh!

oldmud0 Jul 31, 2022

Choose a reason for hiding this comment

Uh oh!

oldmud0 Jul 31, 2022

Choose a reason for hiding this comment

Uh oh!

oldmud0 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Crystalwarrior commented Jun 2, 2022 •

edited

Loading

oldmud0 left a comment •

edited

Loading