fix(ci): resolve all CI failures (frontend tests, specta deps, clippy)#54
Merged
Conversation
- Fix broken import paths in DiffBlade.test.tsx and preferences.test.ts - Add jsdom polyfills for document.queryCommandSupported and window.matchMedia (required by Monaco editor in test environment)
tauri-specta v2.0.0-rc.21 requires specta =2.0.0-rc.22, but Cargo.toml pinned specta =2.0.0-rc.23 causing a dependency resolution failure. Downgrade specta to =2.0.0-rc.22 and specta-typescript to 0.0.9.
- Auto-fix 53 collapsible if-else statements - Fix iterator usage: use .flatten() instead of if let Ok - Change &PathBuf to &Path parameter in get_status_internal - Add #[allow] for dead_code on deserialization-only fields - Add #[allow] for enum_variant_names on ChangelogError
@testing-library/react requires @testing-library/dom as a peer dependency, but it was not explicitly listed in package.json, causing CI to fail with "Cannot find module '@testing-library/dom'".
phmatray
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all CI pipeline failures:
spectato=2.0.0-rc.22andspecta-typescriptto0.0.9to align withtauri-specta 2.0.0-rc.21requirements@testing-library/domas explicit devDependency (peer dep of@testing-library/react)Test plan
npx vitest runpasses all 298 tests across 45 suites locallycargo clippy -- -D warningspasses clean locallycargo testpasses locally