Added Tablature and Fretboard examples#177
Conversation
Added Tablature and Fretboard examples. Cleaned up main view. Removed a few deprecations.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| .package(url: "https://github.com/AudioKit/Flow", from: "1.0.0"), | ||
| .package(url: "https://github.com/AudioKit/PianoRoll", from: "1.0.0"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), | ||
| .package(url: "https://github.com/AudioKit/Tablature", from: "0.1.0"), | ||
| .package(url: "https://github.com/AudioKit/Fretboard", from: "0.1.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| .package(url: "https://github.com/AudioKit/PianoRoll", from: "1.0.0"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), | ||
| .package(url: "https://github.com/AudioKit/Tablature", from: "0.1.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), | ||
| .package(url: "https://github.com/AudioKit/Tablature", from: "0.1.0"), | ||
| .package(url: "https://github.com/AudioKit/Fretboard", from: "0.1.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| .package(url: "https://github.com/AudioKit/PianoRoll", from: "1.0.0"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), | ||
| .package(url: "https://github.com/AudioKit/Tablature", from: "0.1.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), | ||
| .package(url: "https://github.com/AudioKit/Tablature", from: "0.1.0"), | ||
| .package(url: "https://github.com/AudioKit/Fretboard", from: "0.1.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| .package(url: "https://github.com/AudioKit/PianoRoll", from: "1.0.0"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | ||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.11.0"), | ||
| .package(url: "https://github.com/AudioKit/Tablature", from: "0.1.0"), |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| private func startSimulatedInput() { | ||
| let pattern: [(string: Int, fret: Int)] = [ | ||
| (0, 0), (0, 3), (1, 0), (1, 2), (2, 0), (2, 2), | ||
| (3, 0), (3, 2), (4, 0), (4, 3), (5, 0), (5, 3), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| private func startSimulatedInput() { | ||
| let pattern: [(string: Int, fret: Int)] = [ | ||
| (0, 0), (0, 3), (1, 0), (1, 2), (2, 0), (2, 2), | ||
| (3, 0), (3, 2), (4, 0), (4, 3), (5, 0), (5, 3), |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| case channels1to6 = "Ch 1–6" | ||
| case channels11to16 = "Ch 11–16" | ||
|
|
||
| var id: String { rawValue } |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
|
|
||
| private static let instruments: [StringInstrument] = [ | ||
| .guitar, .guitar7String, .guitarDropD, | ||
| .bass, .bass5String, .ukulele, .banjo, |
There was a problem hiding this comment.
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
1 participant
Added Tablature and Fretboard examples.
Cleaned up main view.
Removed a few deprecations.