Merged
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| sampler.stop(noteNumber: 65) | ||
| testMD5(audio) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| audio.append(engine.render(duration: 1.0)) //run test for a second before setting parameters | ||
| sampler.attackDuration = 1.0 | ||
| sampler.load(avAudioFile: file) | ||
| audio.append(engine.render(duration: 1.0))//run test to give time to load |
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| sampler.masterVolume = 1 | ||
| engine.output = sampler | ||
| let audio = engine.startTest(totalDuration: 8.0) | ||
| audio.append(engine.render(duration: 1.0)) //run test for a second before setting parameters |
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| func testSamplerAttackVolumeEnvelope() { | ||
| let engine = AudioEngine() | ||
| let sampleURL = Bundle.module.url(forResource: "TestResources/12345", withExtension: "wav")! | ||
| let file = try! AVAudioFile(forReading: sampleURL) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
| testMD5(audio) | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brute force method to copy parameters from old sampler to newSampler on update.
Also includes test which passes