Conversation
Member
raymondjacobson
left a comment
raymondjacobson
left a comment
There was a problem hiding this comment.
I think this works, but would be less performant than the actual fix I think. I'm fine either way.
The reason for the bug is that the URL is returned from this fn as the redirect on status ok. In the case that we return u on line 52, we should just strip off id3= false, which was used just for the probing.
It looks like this is also the case with skip_play_count... which seems bad
raymondjacobson
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to test:
run
makeagainst prodhit this track on the local server https://api.audius.co/v1/tracks/ryJpOa9/stream
it will still stream but with ffprobe you also get the id3 tags back