Add v1/users/address to find user IDs by associated wallet or account addresses#285
Merged
rickyrombo merged 3 commits intomainfrom Aug 1, 2025
Merged
Add v1/users/address to find user IDs by associated wallet or account addresses#285rickyrombo merged 3 commits intomainfrom
rickyrombo merged 3 commits intomainfrom
Conversation
raymondjacobson
approved these changes
Jul 31, 2025
DejayJD
approved these changes
Aug 1, 2025
schottra
approved these changes
Aug 1, 2025
Contributor
schottra
left a comment
schottra
left a comment
There was a problem hiding this comment.
Minorly grumpy about having multiple endpoints to use for looking up a user by wallet. But, I think this makes sense and is how we would ideally like the other "get user by wallet" endpoints to work.
rickyrombo
changed the title
rickyrombo
added a commit
that referenced
this pull request
Aug 1, 2025
This endpoint doesn't exist in API and is superceded by #285 anyway I propose we remove it entirely. Alternative: mark as deprecated, update loadbalancer to point to dn?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finds user IDs associated with given addresses of wallets or accounts.
This not only enables the Discord bot to do signature recovery and find the relevant account without needing us to change the authentication of the v1/users/account/:wallet route, but also allows for more general user locating based on associated addresses by any means besides just their account wallet, which opens the door to doing "1-click purchase" if a user buys with a connected wallet on a third party site, etc.
TODO: