[API-365] Support validator node type in content node check #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecsavvy
approved these changes
Oct 24, 2025
rickyrombo
approved these changes
Oct 24, 2025
schottra
commented
Oct 24, 2025
| if endpoint.ServiceType == "content-node" || endpoint.ServiceType == "validator" { | ||
| nodes = append(nodes, config.Node{ | ||
| Endpoint: endpoint.Endpoint, | ||
| DelegateOwnerWallet: endpoint.DelegateWallet, |
There was a problem hiding this comment.
cc @alecsavvy
On line 122, we have IsStorageDisabled hard-coded to false because the core rpc doesn't return the value. Can there be validators returned here that don't support storage? If so, we need to get that plumbed through.
There was a problem hiding this comment.
nope, content-nodes and validators MUST (rfc-2119) serve content. otherwise they are subject to slashing. you can infer that it is "on".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support openaudio validator nodes in our content node list.