Skip to content

[API-365] Support validator node type in content node check #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
+1 −1
Merged

[API-365] Support validator node type in content node check #498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/content_node_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func (m *ContentNodeMonitor) getRegisteredNodes(ctx context.Context) ([]config.N
var nodes []config.Node
var endpointStrings []string
for _, endpoint := range endpoints.Msg.Endpoints {
if endpoint.ServiceType == "content-node" {
if endpoint.ServiceType == "content-node" || endpoint.ServiceType == "validator" {
nodes = append(nodes, config.Node{
Endpoint: endpoint.Endpoint,
DelegateOwnerWallet: endpoint.DelegateWallet,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @alecsavvy
On line 122, we have IsStorageDisabled hard-coded to false because the core rpc doesn't return the value. Can there be validators returned here that don't support storage? If so, we need to get that plumbed through.

Copy link
Contributor

@alecsavvy alecsavvy Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, content-nodes and validators MUST (rfc-2119) serve content. otherwise they are subject to slashing. you can infer that it is "on".

Expand Down
Loading