Skip to content

Add GET code/redeem endpoints #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondjacobson merged 4 commits into from
Nov 6, 2025
Merged

Add GET code/redeem endpoints #535

raymondjacobson merged 4 commits into from
Nov 6, 2025

Conversation

@raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Nov 6, 2025 •
edited
Loading 

GET /v1/coins/:mint/redeem
res
{
  amount: 1
}
if code is used or invalid, return 400
{ error: 'used' | 'invalid' }

GET /v1/coins/:mint/redeem/XYZ 
res
{
  code: XYZ,
  amount: 10,
}
if code is used or invalid, return 400
{ error: 'used' | 'invalid' }

rickyrombo
rickyrombo approved these changes Nov 6, 2025
View reviewed changes
ddl/migrations/0182_reward_codes_is_used.sql
@@ -0,0 +1,8 @@
begin;

alter table reward_codes add column if not exists is_used boolean not null default false;
Copy link
Contributor

@rickyrombo rickyrombo Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that I think about it, we could just join on challenge disbursements w/ that specifier but this is probably simpler

Copy link
Member Author

@raymondjacobson raymondjacobson Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good thought. i like this better too though

ddl/migrations/0182_reward_codes_is_used.sql

comment on column reward_codes.is_used is 'Whether the code has been redeemed';

commit;
Copy link
Contributor

@rickyrombo rickyrombo Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ew lowercase sql looks awful 😂

@raymondjacobson raymondjacobson merged commit 5f10e7a into main Nov 6, 2025
5 checks passed
@raymondjacobson raymondjacobson deleted the rj-codes-endpoints branch November 6, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

@schottra schottra Awaiting requested review from schottra

@Kyle-Shanks Kyle-Shanks Awaiting requested review from Kyle-Shanks

@dylanjeffers dylanjeffers Awaiting requested review from dylanjeffers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson @rickyrombo