Clean up nodes, add unsplash, /discovery, /content routes #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyrombo
approved these changes
Dec 17, 2025
Contributor
rickyrombo
left a comment
rickyrombo
left a comment
There was a problem hiding this comment.
A little indirect with the global refresh for the node list living in some extra file and global rendezvous hasher.. but I get it. for testing it might make sense to refactor away from globals in the future.
api/server.go
Outdated
| "started": app.started, | ||
| "uptime": time.Since(app.started).Truncate(time.Second).String(), | ||
| "data": []string{ | ||
| "https://discoveryprovider.audius.co", |
Contributor
There was a problem hiding this comment.
nit: maybe https://api.audius.co? (doesn't this just redirect?)
| Endpoint string | ||
| // The individual wallet address for the node | ||
| DelegateOwnerWallet string | ||
| DelegateWallet string |
| DelegateWallet string | ||
| // The wallet address for the node owner/operator | ||
| OwnerWallet string | ||
| Owner string |
config/nodes.go
Outdated
| // The wallet address for the node owner/operator | ||
| OwnerWallet string | ||
| Owner string | ||
| // Discovery Nodes have storage disabled |
Member
Author
Yeah I agree. I think this PR improves things and doesn't add any new globals really, but it isn't perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get parity with load-balancer frontend, so we can remove it and hit api directly
datafield