Add struct validation for redirect_uris to match indexing#703
Merged
rickyrombo merged 2 commits intomainfrom Mar 9, 2026
Merged
Add struct validation for redirect_uris to match indexing#703rickyrombo merged 2 commits intomainfrom
rickyrombo merged 2 commits intomainfrom
Conversation
raymondjacobson
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit request/body and OpenAPI constraints for redirect_uris so API validation aligns with downstream/indexing expectations.
Changes:
- Add struct-tag validation to
CreateDeveloperAppRequest.RedirectURIsandUpdateDeveloperAppRequest.RedirectURIs(max 50 entries; each max 2000 chars). - Update Swagger schemas to document/enforce the same limits (
maxItems: 50,maxLength: 2000).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| api/v1_users_developer_apps.go | Adds validator constraints to redirect_uris in create/update developer app request structs. |
| api/swagger/swagger-v1.yaml | Documents the same redirect_uris limits in the OpenAPI schema (create, update, and developer_app schemas). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.