Merged
Conversation
raymondjacobson
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the developer apps “include=metrics” endpoint query by removing an invalid GROUP BY on JSON-aggregated redirect URIs, and instead computing metrics via a correlated lateral subquery per app.
Changes:
- Replaced the direct
api_metrics_appsjoin +SUM(...)aggregates with aLEFT JOIN LATERALmetrics subquery. - Removed the
GROUP BYclause that required grouping onoau.redirect_uris(JSON), which cannot be equality-compared in Postgres.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't group by redirect_urls as they're json agged and can't be equality compared. do a lateral join to get stats instead