Fix primary key column order in test schema#779
Merged
rickyrombo merged 2 commits intomainfrom Apr 24, 2026
Merged
Conversation
Put entity ID columns first and txhash last in all composite primary keys, matching the production DP schema. Mismatched PK column order causes the btree index to be useless for entity lookups in tests, masking performance issues that wouldn't appear in production. Tables fixed: users, tracks, playlists, follows, saves, reposts, developer_apps, grants, subscriptions, dashboard_wallet_users Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test database schema dump to align primary key column ordering with production so that query plans in tests better reflect production index usage (entity identifier columns first, txhash last).
Changes:
- Reordered primary key column order for 10 tables in
sql/01_schema.sql(e.g.,users,tracks,playlists,reposts,saves, etc.). - Adjusted
dashboard_wallet_usersprimary key definition to be composite(user_id, wallet).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Production was updated to use PRIMARY KEY (wallet) with a separate index on user_id. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sql/01_schema.sqlto match production: entity ID first, txhash lastTables fixed:
users,tracks,playlists,follows,saves,reposts,developer_apps,grants,subscriptions,dashboard_wallet_usersCompanion ETL migration PR: OpenAudio/go-openaudio#209
Test plan
pg_dumpoutput🤖 Generated with Claude Code