Skip to content

fix(indexer): errgroup.WithContext so ETL halt actually exits the process #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raymondjacobson wants to merge 2 commits into from
+3 −12
Closed

fix(indexer): errgroup.WithContext so ETL halt actually exits the process #884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a55291b
fix(indexer): errgroup.WithContext so ETL halt actually exits the pro…
raymondjacobson May 29, 2026
dc1bde6
Remove comment
raymondjacobson May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions indexer/indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,25 +108,16 @@ func NewIndexer(cfg config.Config) *CoreIndexer {
}
}

// Start runs the ETL indexer alongside the aggregates calculator. Both are
// long-lived; errgroup propagates the first error (and the ctx cancellation
// it triggers) to all members.
//
// Caveat: etl.Indexer.Run() uses its own internal context.Background() rather
// than honoring `ctx` — graceful shutdown via ctx cancellation isn't supported
// by the upstream API today. Process termination (SIGTERM) still works the
// way Go programs always do, and DB connections drain via pool finalizers on
// process exit. Acceptable tradeoff to avoid forking ETL.
func (ci *CoreIndexer) Start(ctx context.Context) error {
eg := errgroup.Group{}
eg, gCtx := errgroup.WithContext(ctx)
eg.Go(func() error {
return ci.aggregatesCalculator.Start(ctx)
return ci.aggregatesCalculator.Start(gCtx)
})
eg.Go(func() error {
ci.logger.Info("Starting ETL indexer")
return ci.etlIndexer.Run()
})
ci.startParityJobs(ctx)
ci.startParityJobs(gCtx)
return eg.Wait()
}

Expand Down
Loading