Skip to content

fix(trending): use bare type strings in trending winners queries #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjeffers merged 1 commit into from
Jun 5, 2026
Merged

fix(trending): use bare type strings in trending winners queries #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/testdata/trending_results_fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ package testdata

var TrendingResultsFixtures = []map[string]any{
// Week 2022-01-21 - tracks 300, 202, 200 (rank 1, 2, 3) - matches trending order
{"user_id": 3, "id": "300", "rank": 1, "type": "TrendingType.TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 2, "id": "202", "rank": 2, "type": "TrendingType.TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 2, "id": "200", "rank": 3, "type": "TrendingType.TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 3, "id": "300", "rank": 1, "type": "TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 2, "id": "202", "rank": 2, "type": "TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 2, "id": "200", "rank": 3, "type": "TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
// Week 2022-01-21 - underground tracks 519, 520, 521 (rank 1, 2, 3)
{"user_id": 8, "id": "519", "rank": 1, "type": "TrendingType.UNDERGROUND_TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 11, "id": "520", "rank": 2, "type": "TrendingType.UNDERGROUND_TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 1, "id": "521", "rank": 3, "type": "TrendingType.UNDERGROUND_TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 8, "id": "519", "rank": 1, "type": "UNDERGROUND_TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 11, "id": "520", "rank": 2, "type": "UNDERGROUND_TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
{"user_id": 1, "id": "521", "rank": 3, "type": "UNDERGROUND_TRACKS", "version": "TrendingVersion.ML51L", "week": "2022-01-21"},
}
2 changes: 1 addition & 1 deletion api/v1_tracks_trending_underground_winners.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (app *ApiServer) v1TracksTrendingUndergroundWinners(c *fiber.Ctx) error {

func (app *ApiServer) getTrendingUndergroundWinnersIds(c *fiber.Ctx, weekParam string) ([]int32, error) {
args := pgx.NamedArgs{
"type": "TrendingType.UNDERGROUND_TRACKS",
"type": "UNDERGROUND_TRACKS",
}

var weekFilter string
Expand Down
2 changes: 1 addition & 1 deletion api/v1_tracks_trending_winners.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (app *ApiServer) v1TracksTrendingWinners(c *fiber.Ctx) error {

func (app *ApiServer) getTrendingWinnersIds(c *fiber.Ctx, weekParam string) ([]int32, error) {
args := pgx.NamedArgs{
"type": "TrendingType.TRACKS",
"type": "TRACKS",
}

var weekFilter string
Expand Down
Loading