TUS: Move logic from UploadPage to a standalone hook #13606
Conversation
|
| audiusSdk, | ||
| userId, | ||
| wallet, | ||
| userId: userId!, |
There was a problem hiding this comment.
we throw an err above on missing userId/wallet, maybe should do the same
There was a problem hiding this comment.
We check inside the hook so that we don't error on render but error when you call the mutation
| ) | ||
| } | ||
|
|
||
| const getTrackArtworkUploadHandles = async ( |
There was a problem hiding this comment.
handle is also overloaded, maybe handler? or just getTrackArtworkUploadTask?
There was a problem hiding this comment.
yeah true. luckily these aren't exported so hopefully clear in context? Task feels fine though too, down to rename in a later pr (don't want to muck the rebasing)
| ) | ||
|
|
||
| return { startUpload, finishUpload } | ||
| } |
rickyrombo
merged commit 67f8c16
into
mjp-tus-edit-replace-audio
Moves all the upload logic from UploadPage into its own hook that can be shared with mobile