Skip to content

Fix playlist contents#13716

Merged
rickyrombo merged 2 commits intomjp-sdk-write-requestsfrom
mjp-sdk-write-requests-albums-stuff
Feb 18, 2026
Merged

Fix playlist contents#13716
rickyrombo merged 2 commits intomjp-sdk-write-requestsfrom
mjp-sdk-write-requests-albums-stuff

Conversation

@rickyrombo
Copy link
Contributor

@rickyrombo rickyrombo commented Feb 17, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 42f3e8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raymondjacobson
raymondjacobson approved these changes Feb 18, 2026
View reviewed changes
packages/common/src/api/tan-query/upload/usePublishCollection.ts Outdated
params.collectionMetadata
)
metadata.playlistContents = publishedTracks.map((t) => ({
metadataTimestamp: Date.now() / 1000,
Copy link
Member

@raymondjacobson raymondjacobson Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't one of these automatically set by block number or something?

Copy link
Contributor Author

@rickyrombo rickyrombo Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah looks like the old version didn't set metadatatimestamp, good catch

Copy link
Contributor Author

@rickyrombo rickyrombo Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but our update method does 😵

dylanjeffers
dylanjeffers approved these changes Feb 18, 2026
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sg

@rickyrombo rickyrombo merged commit 26fc042 into mjp-sdk-write-requests Feb 18, 2026
4 checks passed
@rickyrombo rickyrombo deleted the mjp-sdk-write-requests-albums-stuff branch February 18, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickyrombo @raymondjacobson @dylanjeffers