Add hasRefreshToken guard to token refresh middleware#13858
Merged
rickyrombo merged 2 commits intomjp-oauth-standalonefrom Mar 9, 2026
Merged
Add hasRefreshToken guard to token refresh middleware#13858rickyrombo merged 2 commits intomjp-oauth-standalonefrom
hasRefreshToken guard to token refresh middleware#13858rickyrombo merged 2 commits intomjp-oauth-standalonefrom
Conversation
|
Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on simplifying OAuth refreshToken middleware
Add Mar 9, 2026
hasRefreshToken guard to token refresh middleware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addTokenRefreshMiddlewarewas callingoauth.refreshAccessToken()on every 401, including unauthenticated requests, causing_surfaceError('No refresh token available.')to fire as noise on normal 401 responses.Changes
OAuth.hasRefreshTokengetter — cheap boolean check ontokenStore?.refreshTokenhasRefreshTokenis false, avoiding the noisy error callback entirelyrefreshAccessTokenis never called whenhasRefreshTokenis false🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.