OAuth: lazy-register message listener per login session#13895
Merged
rickyrombo merged 2 commits intoMar 11, 2026
Conversation
|
…register on settle Co-authored-by: rickyrombo <3690498+rickyrombo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on promisifying OAuth service login
OAuth: lazy-register Mar 11, 2026
message listener per login session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
OAuthinstance attached awindow.addEventListener('message', ...)in its constructor and never removed it, causing listener accumulation across multiple SDK instantiations and risking duplicate message processing.Changes
window.addEventListenerno longer called at construction timeloginAsync— listener is attached only when entering thepostMessagepopup flow; guarded against double-registration ifloginAsyncis called again while a login is in progress_settleLogin— listener is removed (and popup check interval cleared) as soon as the login resolves or rejects, via a stored_boundMessageHandlerreferenceremoveEventListener+crypto.getRandomValuesto the window stub; newOAuth message listener lifecyclesuite covering: no listener on construction, listener attached onloginAsync, no duplicate on re-entry, listener removed on settle💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.