Fix SegmentedControl to handle invalid selected values gracefully#14059
Merged
dylanjeffers merged 2 commits intomainfrom Apr 5, 2026
Merged
Fix SegmentedControl to handle invalid selected values gracefully#14059dylanjeffers merged 2 commits intomainfrom
dylanjeffers merged 2 commits intomainfrom
Conversation
When uploadType is INDIVIDUAL_TRACK (0), the selected value doesn't match any option key in TracksPreview's SegmentedControl (which only has INDIVIDUAL_TRACKS=1, ALBUM=3, PLAYLIST=2). The pill falls back to index 0 visually, but isSelected stays false for all options, making all text subdued. Fix by mapping INDIVIDUAL_TRACK to INDIVIDUAL_TRACKS in TracksPreview, and adding a fallback in SegmentedControl to select the first option when the selected value doesn't match any option key. https://claude.ai/code/session_01S8Yn3jaHMpAZ2LRKDoDPfA
🦋 Changeset detectedLatest commit: cb3aa3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14059.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds validation to the SegmentedControl component to gracefully handle cases where the selected value doesn't match any available option, and fixes a bug in TracksPreview where an invalid enum value was being passed.
Key Changes
UploadType.INDIVIDUAL_TRACK(singular) was being passed to SegmentedControl, but the available options only includedUploadType.INDIVIDUAL_TRACKS(plural). Added a mapping to convert the singular enum value to the plural one that matches the available options.Implementation Details
options.some()check to verify the selected value exists before using itoptions[0]?.keyor the raw selected value as a last resorthttps://claude.ai/code/session_01S8Yn3jaHMpAZ2LRKDoDPfA