Fix content visibility logic in search/explore pages#14079
Closed
dylanjeffers wants to merge 1 commit intomainfrom
Closed
Fix content visibility logic in search/explore pages#14079dylanjeffers wants to merge 1 commit intomainfrom
dylanjeffers wants to merge 1 commit intomainfrom
Conversation
Explore sections (recommended tracks, featured playlists, artist spotlight, etc.) were loading too slowly on the default Explore page. This moves them to only appear on their specific sub-tabs (Tracks, Playlists, Albums, Profiles) while keeping the default All tab clean. FanClubsExploreSection moves from All to Profiles tab, and RecentSearches only shows on sub-tabs. Changes apply to web desktop, web mobile, and React Native mobile. https://claude.ai/code/session_018udUfkNDSuFVnRhLkVTgYk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the content visibility logic across search and explore pages by removing the "OR ALL" conditions from individual category checks and introducing explicit handling for the ALL tab.
Key Changes
|| categoryKey === CategoryView.ALL(or|| category === 'all') conditions fromshowTrackContent,showPlaylistContent, andshowUserContentvariables. These now only show content when their specific category is selected.isAllTabvariable to explicitly track when the ALL category is selected.categoryKey === CategoryView.ALLtoshowUserContentfor consistency with other content sections.showUserContextualContentto only showing when!isAllTab && showUserContextualContent, preventing it from appearing on the ALL tab.Implementation Details
The refactoring clarifies the intent: each content section should only display when its specific category tab is active, not when viewing the ALL tab. The ALL tab now has its own explicit logic for determining which sections to display, making the code more maintainable and the behavior more predictable.
https://claude.ai/code/session_018udUfkNDSuFVnRhLkVTgYk