Skip to content

Add contest follower notifications#14159

Merged
dylanjeffers merged 1 commit intomainfrom
contest-notifications
Apr 23, 2026
Merged

Add contest follower notifications#14159
dylanjeffers merged 1 commit intomainfrom
contest-notifications

Conversation

@dylanjeffers
Copy link
Copy Markdown
Contributor

Summary

Adds in-app + push delivery for two new contest notification types and expands the recipient set on existing contest notifications so contest followers (event subscribers) and host followers are first-class citizens.

Indexer (discovery-provider):

  • comment.py writes remix_contest_update to event subscribers when the contest host posts a top-level comment on their event.
  • track.py auto-subscribes the submitter to the contest event on create_track (skips if uploader is the host or already subscribed).
  • utils.py includes contest subscribers in fan_remix_contest_started recipients.
  • fan_remix_contest_ended.py, fan_remix_contest_ending_soon.py, fan_remix_contest_winners_selected.py: union in subscribers + host followers + parent-track savers; explicitly exclude the host (they have the artist_* counterparts).

Frontend (web + mobile + common):

  • New RemixContestUpdate and FanRemixContestSubmission notification types in common, with adapter parsing both camelCase and snake_case keys (so this lands ahead of SDK regen).
  • New web + mobile components, registered in Notification.tsx / NotificationListItem.tsx.
  • Mobile navigation: RemixContestUpdate → contest entity, FanRemixContestSubmission → submitted remix track.

Test:

  • Updated test_event_comment.py for the new entity_id / entity_user_id data shape.

Pairs with:

Test plan

  • After all three land, create a contest, submit a remix from a second account → submitter is auto-subscribed; host + any subscribers see fan_remix_contest_submission in-app and push
  • Host posts a top-level comment on the event → subscribers see remix_contest_update in-app and push; host's own replies do NOT trigger it
  • Subscribe to a contest from a third account → see fan_remix_contest_started (if unlisted→public happens after subscribing), _ending_soon, _ended, and _winners_selected in addition to remixers/host followers/savers
  • Verify host does not receive the fan_* versions of ended / ending_soon / winners_selected

🤖 Generated with Claude Code

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 23, 2026

⚠️ No Changeset found

Latest commit: e2ff397

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers dylanjeffers merged commit b970ead into main Apr 23, 2026
5 checks passed
@dylanjeffers dylanjeffers deleted the contest-notifications branch April 23, 2026 20:27
@github-actions
Copy link
Copy Markdown
Contributor

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14159.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant