Add contest follower notifications#14159
Merged
dylanjeffers merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14159.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds in-app + push delivery for two new contest notification types and expands the recipient set on existing contest notifications so contest followers (event subscribers) and host followers are first-class citizens.
Indexer (discovery-provider):
comment.pywritesremix_contest_updateto event subscribers when the contest host posts a top-level comment on their event.track.pyauto-subscribes the submitter to the contest event oncreate_track(skips if uploader is the host or already subscribed).utils.pyincludes contest subscribers infan_remix_contest_startedrecipients.fan_remix_contest_ended.py,fan_remix_contest_ending_soon.py,fan_remix_contest_winners_selected.py: union in subscribers + host followers + parent-track savers; explicitly exclude the host (they have the artist_* counterparts).Frontend (web + mobile + common):
RemixContestUpdateandFanRemixContestSubmissionnotification types incommon, with adapter parsing both camelCase and snake_case keys (so this lands ahead of SDK regen).Notification.tsx/NotificationListItem.tsx.RemixContestUpdate→ contest entity,FanRemixContestSubmission→ submitted remix track.Test:
test_event_comment.pyfor the newentity_id/entity_user_iddata shape.Pairs with:
Test plan
fan_remix_contest_submissionin-app and pushremix_contest_updatein-app and push; host's own replies do NOT trigger itfan_remix_contest_started(if unlisted→public happens after subscribing),_ending_soon,_ended, and_winners_selectedin addition to remixers/host followers/saversfan_*versions of ended / ending_soon / winners_selected🤖 Generated with Claude Code